Add generic check for packages #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rnestler I probably won't find the time to review this soon. If you think it works, go ahead (and don't wait for my reviews in this project) 🙂 |
rnestler
force-pushed
the
add-generic-checks
branch
2 times, most recently
from
afc776d to
53d3471
Compare
This allows to implement main generically while beeing able to easily add more checks.
It already is a reference type which is trivially copyable.
This check just compares the install date of a list of packages to the time of the last boot.
The messages now come from the CheckResult, which allows us to easily set different results.
The kernel version is the only thing that needs cleanup. For all other packages we don't care about the version string that much. We also add some more tests to make sure it behaves correctly.
The check didn't trigger a notification anyways and didn't really work when running on wayland.
rnestler
force-pushed
the
add-generic-checks
branch
from
4bdff9e to
00c483a
Compare
* Update the example terminal output * Mention that it can watch other critical parts of the system
|
@dbrgn I'd also appreciate if you could just run it and see if it behaves like you'd expect it to 🙂 |
|
I ran it, seems to work fine! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step in fixing #5