convert many subroutines to use signatures #708
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, I used a small program (included below) to automatically convert
existing subroutines, which use @_, to use signatures. This will not
have been comprehensive. Some use "shift" to get signatures. Also, the
program will not upgrade anonymous subroutines. And there are probably
other shortfalls.
Then, I ran the tests repeatedly and corrected errors that were exposed,
most of which were related to arguments that were optional but had been
(of course) converted to mandatory arguments.
This may well affect some plugins downstream, so we'll want to do a
bunch of testing before deciding this is a good idea!
#!/bin/env perl
use v5.36.0;
my $fn = $ARGV[0];
my @output;
{
open my $fh, '<', $fn;
my @input = <$fh>;
LINE: while (my $line = shift @input) {
if ($line =~ /^sub (\S+) \{$/) {
my $sub = $1;
my $next = shift @input;
if ($next && $next =~ /^\s*my (\([^)]+\)) = \@_;$/) {
my $sig = $1;
my $new_line = "sub $sub $sig {\n";
warn $new_line;
push @output, $new_line;
while (@input && $input[0] !~ /\S/) {
shift @input;
}
next LINE;
}
unshift @input, $next;
}
push @output, $line;
}
}
open my $fh, '>', $fn;
print {$fh} @output;
close $fh;
rjbs
force-pushed
the
main
branch
10 times, most recently
from
9361f28 to
f825e3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.