Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename fs executor mods #20322

Merged
merged 2 commits into from
Jan 27, 2025
Merged

refactor: rename fs executor mods #20322

merged 2 commits into from
Jan 27, 2025

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Jan 27, 2025

To make it more clear.

Signed-off-by: xxchan [email protected]

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

To make it more clear.

Signed-off-by: xxchan <[email protected]>
Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's try deprecate it after CNY.

Signed-off-by: xxchan <[email protected]>
Copy link

gru-agent bot commented Jan 27, 2025

This pull request has been modified. If you want me to regenerate unit test for any of the files related, please find the file in "Files Changed" tab and add a comment @gru-agent. (The github "Comment on this file" feature is in the upper right corner of each file in "Files Changed" tab.)

@xxchan
Copy link
Member Author

xxchan commented Jan 27, 2025

LGTM, let's try deprecate it after CNY.

Do you mean fully delete code? Is the compatibility breakage ok? 🤔

xxchan added a commit that referenced this pull request Jan 27, 2025
follow up #20322, but in connector crate
Copy link
Member Author

xxchan commented Jan 27, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

xxchan added a commit that referenced this pull request Jan 27, 2025
follow up #20322, but in connector crate
@xxchan xxchan added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit cdfdb97 Jan 27, 2025
33 of 34 checks passed
@xxchan xxchan deleted the xxchan/musical-koala branch January 27, 2025 06:31
xxchan added a commit that referenced this pull request Jan 27, 2025
follow up #20322, but in connector crate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants