fix: Fix the issue of actor migration panic caused by the in-place scale-down #20316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type/fix
…r & controller Signed-off-by: Shanicky Chen <[email protected]>
shanicky
force-pushed
the
peng/fix-mig
branch
from
779c310 to
62107b8
Compare
|
This pull request has been modified. If you want me to regenerate unit test for any of the files related, please find the file in "Files Changed" tab and add a comment |
shanicky
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-actions bot
pushed a commit
that referenced
this pull request
Jan 27, 2025
…ale-down (#20316) Signed-off-by: Shanicky Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
In certain situations, a worker node may experience an in-place parallelism reduction, potentially leading to a scenario where some actors of the worker do not need to be migrated. As a result, the worker slot containing these actors is not included in the plan. The solution is straightforward: simply skip this worker slot.
Checklist