Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compactor): fix full key can concat #20314

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Conversation

Li0k
Copy link
Contributor

@Li0k Li0k commented Jan 26, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

When ckpt > 1, the same user key may exist in different ssts in the overlapping sublevel.

Therefore the epoch in the full key should be considered in the judgement of can concat.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@Li0k Li0k enabled auto-merge January 26, 2025 09:10
…nto li0k/storage_fix_full_key_can_concat
Copy link

gru-agent bot commented Jan 26, 2025

This pull request has been modified. If you want me to regenerate unit test for any of the files related, please find the file in "Files Changed" tab and add a comment @gru-agent. (The github "Comment on this file" feature is in the upper right corner of each file in "Files Changed" tab.)

@Li0k Li0k added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit 6bf7184 Jan 27, 2025
28 of 29 checks passed
@Li0k Li0k deleted the li0k/storage_fix_full_key_can_concat branch January 27, 2025 03:02
github-actions bot pushed a commit that referenced this pull request Jan 27, 2025
github-actions bot pushed a commit that referenced this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants