feat(iceberg): support iceberg engine connection #20298
Conversation
| ); | ||
|
|
||
| statement ok | ||
| set iceberg_engine_connection = 'public.my_conn'; |
There was a problem hiding this comment.
Why don't we use the connection = conn syntax, but use a session variable instead? :thinking
There was a problem hiding this comment.
Finding a way to allow users to set a default behavior for a whole database. Adding a syntax is also ok, however, our iceberg table can be used with a connector which also can have a connection. This might be somewhat confusing for the user.
There was a problem hiding this comment.
Oh, that's indeed a problem... So the with can be both for connector and for the table.
There was a problem hiding this comment.
crunchybridge https://arc.net/l/quote/vdcxffua
snowflake https://arc.net/l/quote/fomfghdw
Both of them allow the setting of a variable in a database.
|
This pull request has been modified. If you want me to regenerate unit test for any of the files related, please find the file in "Files Changed" tab and add a comment |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
iceberg_engine_connectionto allow users to provide their own bucket for the iceberg engine via iceberg connection. Currently, only warehouse information is allowed to be configured in the iceberg engine connection. Iceberg catalog is still handled by us in the meta sql backend. With this config, it can make us much easier to share iceberg tables with users, since the underlying warehouse is managed by users and they can have a better control of the warehouse credential.Checklist
Documentation
Release note