-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the DataContext type mismatch error message #1892
Draft
exyi
wants to merge
13
commits into
resource-datacontext
Choose a base branch
from
datacontext-mismatch-fancy-error
base: resource-datacontext
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This functionality is essential for server-side only rendering, but this patch is only the groundwork - we still need to add support to Repeater and possibly other controls. The design is fairly simple - we allow resource binding in data context and track that this data context does not exist client-side (see the new ServerSideOnly property). Using this server-only data context is not allowed in value and staticCommand bindings. Note that using a value binding inside the resource-bound control is allowed, it just cannot reference `_this`. Since the context does not exist client-side, we then translate _parent into $data instead of $parent.
* ExpectedType property can now be null, when the assigned property is unknwon: - this means that CreateBinding will actually create a strongly typed instance, instead of just ValueBindingExpression<object> or similar * AutoUI uses props.Property instead of CreateValueBinding where possible
bc1e371
to
27ae8e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.