-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mrc-6176 run discrete system #5
Open
EmmaLRussell
wants to merge
16
commits into
main
Choose a base branch
from
mrc-6176
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 5 +2
Lines 60 139 +79
Branches 11 15 +4
=========================================
+ Hits 60 139 +79 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch builds on the original WIP commit for a discrete system, which applies a generator to a state. Various bits of tidying up, validation and tests.
A couple of things to note:
SystemState
to represent the multidimensional state array, whose values can be fetched and updated per particle. This is similar to the implementation in original dust-js, and uses the scijs ndarray rather than the stdlib ndarry, which turns out to be unwritable by slice! However, the Packer still uses stdlib's ndarray! I'll fix this in another ticket.TShared
andTInternal
(which seemed weird). it's now taking the generator typeTGenerator
instead, and usinginfer
to work out the correct Shared and Internal types from whatever Generator gets fed in. The syntax for this is weird, and is oddly tied to conditional types. @M-Kusumgar may have some thoughts on this!