Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix request matching with Vary and redirects #835

Merged
merged 2 commits into from
Jun 5, 2023
Merged

Conversation

JWCook
Copy link
Member

@JWCook JWCook commented Jun 2, 2023

Fixes #809, fixes #836

@JWCook JWCook added the bug label Jun 2, 2023
@JWCook JWCook added this to the v1.1 milestone Jun 2, 2023
@JWCook JWCook force-pushed the vary-with-redirects branch from 14d5bac to f108ce7 Compare June 2, 2023 21:56
@JWCook JWCook marked this pull request as ready for review June 2, 2023 21:57
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #835 (636e2ad) into main (7501183) will decrease coverage by 0.17%.
The diff coverage is 50.00%.

❗ Current head 636e2ad differs from pull request most recent head af235ec. Consider uploading reports for the commit af235ec to get more accurate results

@@            Coverage Diff             @@
##             main     #835      +/-   ##
==========================================
- Coverage   99.45%   99.29%   -0.17%     
==========================================
  Files          23       23              
  Lines        1826     1831       +5     
  Branches      307      308       +1     
==========================================
+ Hits         1816     1818       +2     
- Misses          5        8       +3     
  Partials        5        5              
Impacted Files Coverage Δ
requests_cache/serializers/cattrs.py 93.90% <25.00%> (-3.54%) ⬇️
requests_cache/policy/actions.py 100.00% <100.00%> (ø)

@JWCook JWCook force-pushed the vary-with-redirects branch 5 times, most recently from 127cebf to 3e24f27 Compare June 5, 2023 19:44
@JWCook JWCook marked this pull request as draft June 5, 2023 20:03
@JWCook JWCook force-pushed the vary-with-redirects branch from 3e24f27 to 84ebea2 Compare June 5, 2023 22:03
@JWCook JWCook force-pushed the vary-with-redirects branch from 84ebea2 to 636e2ad Compare June 5, 2023 22:18
@JWCook JWCook force-pushed the vary-with-redirects branch from 636e2ad to af235ec Compare June 5, 2023 22:47
@JWCook JWCook marked this pull request as ready for review June 5, 2023 22:48
@JWCook JWCook merged commit e519e71 into main Jun 5, 2023
@JWCook JWCook deleted the vary-with-redirects branch June 5, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant