Skip to content
This repository was archived by the owner on Feb 10, 2025. It is now read-only.

Refactor match history elo view #154

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Panuchi
Copy link

@Panuchi Panuchi commented Jun 11, 2024

Situation:
When you win, it happens that ELO is taken away, and it is not working in your extansion

How it works in your extension:
The ELO change for the match is not displayed
yourExtension

How it looks in my update:
myPR

P.S. I don’t know why the faceit was taken away ELO for the victory, although the person was top 2 in the team, perhaps the teammates sent reports.

@Panuchi
Copy link
Author

Panuchi commented Jun 11, 2024

@timche i am waiting your review, thanks

@DarkTwistter
Copy link
Contributor

@Panuchi it might be the case for a banned opponent or teammate, when ELO gets reverted by one or more matches.

In other words, your elo got rolled back due to friend got banned in between those 2 matches

@Panuchi
Copy link
Author

Panuchi commented Jul 2, 2024

@Panuchi it might be the case for a banned opponent or teammate, when ELO gets reverted by one or more matches.

In other words, your elo got rolled back due to friend got banned in between those 2 matches

It is clear that the reasons may be different, but still the extension must handle this case

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants