Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect to a dApp with SA, create SA on building a crypto link #479

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

Bacis
Copy link
Contributor

@Bacis Bacis commented Feb 12, 2024

Screenshot 2024-02-12 at 12 05 06

Filtered only allowed chains when connecting SA. If SA is available, make sure it is the one that gets displayed on the dApp you connect.

Copy link

vercel bot commented Feb 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
decentralized-relay-wallet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2024 11:18am
react-wallet-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2024 11:18am
10 Ignored Deployments
Name Status Preview Comments Updated (UTC)
decentralized-relay-app ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2024 11:18am
malicious-dapp-verify-simulation ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2024 11:18am
react-auth-dapp ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2024 11:18am
react-auth-wallet ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2024 11:18am
react-dapp-v2 ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2024 11:18am
react-dapp-v2-cosmos-provider ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2024 11:18am
react-dapp-v2-with-ethers ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2024 11:18am
react-dapp-v2-with-web3js ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2024 11:18am
svelte-web3modal ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2024 11:18am
vue-dapp-auth ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2024 11:18am

Copy link
Contributor

@arein arein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra points for a Unit Test to cover regressions

also consider adding a toggle for this in settings such that we can integration test both cases

Comment on lines +285 to +286
// when SA available, make it 1st on dApp
namespaces.eip155.accounts = [`${nameSpaceKey}:${chain.id}:${smartAccountAddress.address}`, ...allowedAccounts]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @Sam-Newman for multiaddress

@Bacis Bacis changed the title connect to peanut with SA, create SA on building a crypto link connect to a dApp with SA, create SA on building a crypto link Feb 12, 2024
@arein arein merged commit 8a8fe68 into main Feb 12, 2024
14 of 15 checks passed
@arein arein deleted the feat/peanut-test-case branch February 12, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants