Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix for wallet3inbox connection #469

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Conversation

Bacis
Copy link
Contributor

@Bacis Bacis commented Feb 9, 2024

https://files.slack.com/files-pri/TB3H1FRHU-F06JGM2L94H/screenshot_2024-02-09_at_12.17.33___pm.png

Connection on wallet3inbox hanged on approval.

Added error handling and validation to skip SA connection when there are none

@Bacis Bacis requested a review from arein February 9, 2024 17:42
Copy link

vercel bot commented Feb 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
decentralized-relay-wallet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2024 5:56pm
react-auth-dapp 🔄 Building (Inspect) Visit Preview 💬 Add feedback Feb 9, 2024 5:56pm
react-wallet-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2024 5:56pm
9 Ignored Deployments
Name Status Preview Comments Updated (UTC)
decentralized-relay-app ⬜️ Ignored (Inspect) Visit Preview Feb 9, 2024 5:56pm
malicious-dapp-verify-simulation ⬜️ Ignored (Inspect) Visit Preview Feb 9, 2024 5:56pm
react-auth-wallet ⬜️ Ignored (Inspect) Feb 9, 2024 5:56pm
react-dapp-v2 ⬜️ Ignored (Inspect) Visit Preview Feb 9, 2024 5:56pm
react-dapp-v2-cosmos-provider ⬜️ Ignored (Inspect) Visit Preview Feb 9, 2024 5:56pm
react-dapp-v2-with-ethers ⬜️ Ignored (Inspect) Visit Preview Feb 9, 2024 5:56pm
react-dapp-v2-with-web3js ⬜️ Ignored (Inspect) Visit Preview Feb 9, 2024 5:56pm
svelte-web3modal ⬜️ Ignored (Inspect) Visit Preview Feb 9, 2024 5:56pm
vue-dapp-auth ⬜️ Ignored (Inspect) Visit Preview Feb 9, 2024 5:56pm

Copy link
Contributor

@arein arein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icing on top would be a unit/functional tests so we prevent regessions but as a hotfix this is great

@@ -39,8 +39,6 @@ export class SmartAccountLib {
throw new Error('A Pimlico API Key is required')
}

console.log('investigate 2', chain, privateKey, sponsored)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love me some private Key logging :)

@arein arein requested a review from ganchoradkov February 9, 2024 17:50
@arein arein merged commit e362091 into main Feb 9, 2024
14 of 15 checks passed
@arein arein deleted the fix/wallet3inbox-connect-hotfix branch February 9, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants