-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hotfix for wallet3inbox connection #469
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Icing on top would be a unit/functional tests so we prevent regessions but as a hotfix this is great
@@ -39,8 +39,6 @@ export class SmartAccountLib { | |||
throw new Error('A Pimlico API Key is required') | |||
} | |||
|
|||
console.log('investigate 2', chain, privateKey, sponsored) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love me some private Key logging :)
https://files.slack.com/files-pri/TB3H1FRHU-F06JGM2L94H/screenshot_2024-02-09_at_12.17.33___pm.png
Connection on wallet3inbox hanged on approval.
Added error handling and validation to skip SA connection when there are none