Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 1Inch gas estimation has decimals #953

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

chris13524
Copy link
Member

Description

Fix bad floating point math that can sometimes result in decimals.

Slack conversation

How Has This Been Tested?

Not tested

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@chris13524 chris13524 self-assigned this Feb 12, 2025
@chris13524 chris13524 force-pushed the fix/1inch-gas-decimals branch from c826fdb to 618c5c1 Compare February 12, 2025 19:07
@chris13524 chris13524 merged commit f32790a into master Feb 12, 2025
15 checks passed
@chris13524 chris13524 deleted the fix/1inch-gas-decimals branch February 12, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants