Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: initialize solana connection on adapter construction #3860

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tomiir
Copy link
Collaborator

@tomiir tomiir commented Feb 13, 2025

Description

  • Initializes solana connection on adapter construction instead of waiting for connection

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Feb 13, 2025

🦋 Changeset detected

Latest commit: 98a9b88

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-common Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 5:03pm
appkit-ethers5-bera ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 5:03pm
appkit-laboratory ❌ Failed (Inspect) Feb 13, 2025 5:03pm
next-wagmi-solana-bitcoin-example ❌ Failed (Inspect) Feb 13, 2025 5:03pm
9 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-ep ⬜️ Ignored (Inspect) Feb 13, 2025 5:03pm
appkit-basic-ep-example ⬜️ Ignored (Inspect) Feb 13, 2025 5:03pm
appkit-basic-example ⬜️ Ignored (Inspect) Feb 13, 2025 5:03pm
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Feb 13, 2025 5:03pm
appkit-basic-up-example ⬜️ Ignored (Inspect) Feb 13, 2025 5:03pm
appkit-vue-solana ⬜️ Ignored (Inspect) Feb 13, 2025 5:03pm
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Feb 13, 2025 5:03pm
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Feb 13, 2025 5:03pm
vue-wagmi-example ⬜️ Ignored (Inspect) Feb 13, 2025 5:03pm

Copy link
Contributor

Warnings
⚠️ File packages/adapters/solana/src/client.ts contains a KEY or SECRET
⚠️ File packages/adapters/solana/src/tests/client.test.ts contains a KEY or SECRET

Generated by 🚫 dangerJS against 98a9b88

Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 69.01% 20214 / 29289
🔵 Statements 69.01% 20214 / 29289
🔵 Functions 60.97% 1789 / 2934
🔵 Branches 80.71% 3759 / 4657
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/adapters/solana/src/client.ts 52.67% 76.92% 36.66% 52.67% 55-62, 66-67, 94-97, 100-103, 106-107, 110-111, 114-115, 118-126, 133-134, 144-164, 167-200, 203-204, 207-208, 216-217, 255-256, 278-280, 283-287, 293, 308-314, 317-324, 339-340, 346-350, 353-359
Generated in workflow #9563 for commit 98a9b88 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant