Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use portofolio UI for all wallets #3859

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tomiir
Copy link
Collaborator

@tomiir tomiir commented Feb 13, 2025

Description

  • Removes default account widget
  • Uses portfolio view for all wallets
  • Fixes issue where on non-embedded wallets, account would not switch.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

Closes APKT-2049

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests) => WIP
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

linear bot commented Feb 13, 2025

Copy link

changeset-bot bot commented Feb 13, 2025

⚠️ No Changeset found

Latest commit: 2a6a173

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 2:43pm
appkit-ethers5-bera ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 2:43pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 2:43pm
next-wagmi-solana-bitcoin-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 2:43pm
9 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-ep ⬜️ Ignored (Inspect) Feb 13, 2025 2:43pm
appkit-basic-ep-example ⬜️ Ignored (Inspect) Feb 13, 2025 2:43pm
appkit-basic-example ⬜️ Ignored (Inspect) Feb 13, 2025 2:43pm
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Feb 13, 2025 2:43pm
appkit-basic-up-example ⬜️ Ignored (Inspect) Feb 13, 2025 2:43pm
appkit-vue-solana ⬜️ Ignored (Inspect) Feb 13, 2025 2:43pm
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Feb 13, 2025 2:43pm
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Feb 13, 2025 2:43pm
vue-wagmi-example ⬜️ Ignored (Inspect) Feb 13, 2025 2:43pm

Copy link
Contributor

Warnings
⚠️ File packages/appkit/src/client.ts contains a KEY or SECRET
⚠️ File packages/appkit/tests/client/public-methods.test.ts contains a KEY or SECRET
⚠️ File packages/scaffold-ui/src/views/w3m-account-view/index.ts contains a KEY or SECRET
⚠️ File packages/scaffold-ui/src/views/w3m-profile-view/index.ts contains a KEY or SECRET

Generated by 🚫 dangerJS against 2a6a173

Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 68.26% 19766 / 28956
🔵 Statements 68.26% 19766 / 28956
🔵 Functions 60.12% 1743 / 2899
🔵 Branches 80.89% 3637 / 4496
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit/src/client.ts 59.88% 83.48% 76.56% 59.88% 182-183, 215-216, 236-237, 240-241, 256-259, 262-265, 285-286, 289-290, 306-340, 343-352, 363-364, 614-615, 618-621, 624-625, 628-629, 632-633, 636-637, 644-648, 713-723, 732-757, 764-767, 794-795, 809-810, 819-820, 823-824, 829-830, 854-855, 858-862, 890-896, 922-933, 936-972, 975-980, 996-1000, 1013-1024, 1027-1046, 1049-1055, 1058-1068, 1071-1083, 1086-1088, 1091-1093, 1096-1098, 1101-1103, 1106-1113, 1118-1176, 1184-1196, 1207-1221, 1224-1231, 1234-1245, 1248-1254, 1259, 1263, 1278, 1291-1292, 1300-1303, 1306-1309, 1312-1318, 1328-1329, 1361-1377, 1389-1392, 1396, 1412-1422, 1431-1432, 1443-1461, 1467-1474, 1478-1493, 1511-1521, 1524-1604, 1607-1627, 1645, 1661-1662, 1668, 1670-1686, 1691, 1703, 1741-1748, 1750-1761, 1764-1772, 1810-1813, 1820-1826, 1833-1834, 1839-1840, 1880-1881, 1894-1895, 1900-1901, 1903-1904, 1909-1912, 1923-1924, 1963-1967, 1992-1993, 2017-2018, 2048-2049, 2053-2054, 2152-2153, 2182-2187, 2189-2199, 2201, 2203-2215, 2217-2231, 308-344
packages/scaffold-ui/exports/index.ts 100% 100% 100% 100%
packages/scaffold-ui/src/views/w3m-account-view/index.ts 26% 100% 10% 26% 61, 64-72, 75, 85-87, 90-91, 95-129, 133-157, 160-175, 178-195, 198-214, 217-233, 243-250, 253-264, 267-275, 278-279, 282-289, 292-293, 296-316, 319-320, 323-334, 312-331
packages/scaffold-ui/src/views/w3m-profile-view/index.ts 87% 77.77% 77.77% 87% 45, 53, 58, 64-65, 119, 131, 140-142, 161, 171-172
Generated in workflow #9554 for commit 2a6a173 by the Vitest Coverage Report Action

@lukaisailovic
Copy link
Collaborator

How many portfolio API Calls are we making?

Copy link
Contributor

@arein arein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should make /portfolio calls for all wallets. If we want to we need a cost forecast please and make sure that the call is only triggered when the user actually opens the account modal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants