chore: erc3770 chain specific addresses #3848
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Skipped Deployments
|
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
…nd remove old implementation
|
@tomiir I added viem for address validation. I don't think the bundle size is a concern for experimental package. Wdyt |
| describe('ConverterUtil', () => { | ||
| describe('convertCaip10ToErc3770', () => { | ||
| it('should convert Ethereum mainnet CAIP address to ERC-3770 format with checksum', () => { | ||
| const caipAddress = 'eip155:1:0xfb6916095ca1df60bb79ce92ce3ea74c37c5d359' |
There was a problem hiding this comment.
this is what I call a test file
| namespace === undefined || | ||
| chainId === undefined || | ||
| address === undefined |
There was a problem hiding this comment.
nit: do we need explicit check agains undefined?
There was a problem hiding this comment.
Typescript will complain down below when using the chainId and namespace so I just added validation for everything in one go
| } | ||
|
|
||
| const createErc3770Address = (address: string, chainId: string): string => { | ||
| const shortName = ConstantsUtil.CHAIN_NAMES[chainId] |
There was a problem hiding this comment.
is this something we need to mantain or is there a public registry we can use? should this maybe be some api endpoint?
There was a problem hiding this comment.
There is a public registry https://github.com/ethereum-lists/chains
I would consider moving it to an API or just modifying the json with the chains we support if we wanted to go in prod with it
There was a problem hiding this comment.
We can just query them from here (not directly ofc) https://chainid.network/chains_mini.json, but its an additional unnecessary request atm
Description
Adding support for displaying chain-specific addresses following the ERC-3770. When a user connects with an EIP-155 compatible wallet, the address will be displayed in both CAIP and ERC-3770 formats.
We're also exporting a utility from experimental package to convert CAIP-10 to ERC-3770
and another one to construct ERC3770 address on its own
Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
Checklist