Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: react version 19 #3785

Merged
merged 12 commits into from
Feb 14, 2025
Merged

feat: react version 19 #3785

merged 12 commits into from
Feb 14, 2025

Conversation

magiziz
Copy link
Contributor

@magiziz magiziz commented Feb 3, 2025

Description

  • Updated react, react-dom, @types/react and @types/react-dom to version 19

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-2035

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

linear bot commented Feb 3, 2025

Copy link

changeset-bot bot commented Feb 3, 2025

🦋 Changeset detected

Latest commit: cea0d25

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-wallet-button Patch
@reown/appkit Patch
@reown/appkit-ui Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-common Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-wallet Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-demo 🛑 Canceled (Inspect) Feb 14, 2025 10:41am
appkit-ethers5-bera 🛑 Canceled (Inspect) Feb 14, 2025 10:41am
appkit-laboratory 🛑 Canceled (Inspect) 💬 Add feedback Feb 14, 2025 10:41am
next-wagmi-solana-bitcoin-example 🛑 Canceled (Inspect) Feb 14, 2025 10:41am
9 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-ep ⬜️ Ignored (Inspect) Feb 14, 2025 10:41am
appkit-basic-ep-example ⬜️ Ignored (Inspect) Feb 14, 2025 10:41am
appkit-basic-example ⬜️ Ignored (Inspect) Feb 14, 2025 10:41am
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Feb 14, 2025 10:41am
appkit-basic-up-example ⬜️ Ignored (Inspect) Feb 14, 2025 10:41am
appkit-vue-solana ⬜️ Ignored (Inspect) Feb 14, 2025 10:41am
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Feb 14, 2025 10:41am
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2025 10:41am
vue-wagmi-example ⬜️ Ignored (Inspect) Feb 14, 2025 10:41am

Copy link
Contributor

github-actions bot commented Feb 3, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 71.21% 22446 / 31517
🔵 Statements 71.21% 22446 / 31517
🔵 Functions 61.01% 1789 / 2932
🔵 Branches 80.77% 3774 / 4672
File CoverageNo changed files found.
Generated in workflow #9584 for commit e241272 by the Vitest Coverage Report Action

Copy link
Contributor

github-actions bot commented Feb 13, 2025

Warnings
⚠️ File apps/browser-extension/package.json contains a KEY or SECRET
⚠️ File apps/browser-extension/src/css/atoms.ts contains a KEY or SECRET
⚠️ File packages/wallet-button/exports/react.ts contains a KEY or SECRET
⚠️ File packages/wallet-button/package.json contains a KEY or SECRET

Generated by 🚫 dangerJS against e241272

Copy link
Contributor

@enesozturk enesozturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure this is working as expected for lower React versions too

@magiziz
Copy link
Contributor Author

magiziz commented Feb 14, 2025

Tried React 18 and worked fine.

"react": "18.3.1",
"react-dom": "18.3.1",
"@types/react": "18.2.62",
"@types/react-dom": "18.2.7",

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants