feat: appkit basic code-split #3757
Conversation
… due to lack of import
…nto chore/ui-re-exporting
…nto chore/ui-re-exporting
…nto chore/ui-re-exporting
| @@ -47,10 +52,24 @@ describe('Balance sync', () => { | |||
| expect(setBalanceSpy).toHaveBeenCalledWith('1.00', 'ETH', sepolia.chainNamespace) | |||
| }) | |||
|
|
|||
| it('should set the correct native token balance', async () => { | |||
| it.sequential('should set the correct native token balance', async () => { | |||
There was a problem hiding this comment.
@enesozturk did we need to do this for other tests too ?
There was a problem hiding this comment.
@magiziz For async tests we 'might' need. When there are async test, and if they are trying to mock same module, or some how the internal functions relying on the same state, not using sequentia might cause race condition issues which would be painful to debug
Co-authored-by: Sven <[email protected]>
| @@ -182,7 +133,7 @@ export class WuiIcon extends LitElement { | |||
| --local-width: ${`var(--wui-icon-size-${this.size});`} | |||
| ` | |||
|
|
|||
| return html`${svgOptions[this.name]}` | |||
| return html`${until(getSvg(this.name), html`<div class="fallback"></div>`)}` | |||
There was a problem hiding this comment.
This is nice! Can we maybe use until in more places where we load stuff to minimise dom rendering?
There was a problem hiding this comment.
yeah definitely, we can probably do it after appkit core split
| @@ -98,7 +109,6 @@ export class W3mAccountWalletFeaturesWidget extends LitElement { | |||
| gap="m" | |||
| data-testid="w3m-account-wallet-features-widget" | |||
| > | |||
| ${this.network && html`<wui-network-icon .network=${this.network}></wui-network-icon>`} | |||
There was a problem hiding this comment.
remember this was not being rendered?
… into feat/appkit-basic-class
| @@ -21,6 +21,19 @@ describe('SIWE mapped to SIWX', () => { | |||
| let appkit: AppKit | |||
|
|
|||
| beforeEach(async () => { | |||
| global.document = { | |||
There was a problem hiding this comment.
Can we use mockWindowAndDocument method which is mocking document and window object, if it's not doing the exact same, we could extend it maybe?
Description
Type of change
Checklist