Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/coinbase #115

Merged
merged 26 commits into from
Jan 5, 2024
Merged

Feat/coinbase #115

merged 26 commits into from
Jan 5, 2024

Conversation

ignaciosantise
Copy link
Collaborator

@ignaciosantise ignaciosantise commented Dec 19, 2023

Summary

  • Added coinbase connector
  • Added connectors controller logic

Screenshots

coinbase-android.mp4
coinbase-ios.mov

Canary version:

@web3modal/[email protected]
@web3modal/[email protected]
@web3modal/[email protected]
@web3modal/[email protected]
@web3modal/[email protected]
@web3modal/[email protected]

Closes #9

Copy link
Contributor

github-actions bot commented Dec 19, 2023

Qodana for JS

7 new problems were found

Inspection name Severity Problems
Result of method call returning a promise is ignored ◽️ Notice 6
Missing await for an async function call ◽️ Notice 1
@@ Code coverage @@
- 45% total lines covered
379 lines analyzed, 174 lines covered
! 37% fresh lines covered
37 lines analyzed, 14 lines covered
# Calculated according to the filters of your coverage tool

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@reown-com reown-com deleted a comment from github-actions bot Dec 19, 2023
Copy link
Contributor

github-actions bot commented Dec 19, 2023

🚀 Expo preview is ready!

  • Project → web3modal-sdk
  • Platforms → android, ios
  • Runtime Version → 1.0.0
  • More info

Learn more about 𝝠 Expo Github Action

@ignaciosantise ignaciosantise merged commit 90768fd into V1 Jan 5, 2024
4 checks passed
@ignaciosantise ignaciosantise deleted the feat/coinbase branch January 5, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: support Coinbase wallet
2 participants