Skip to content

Commit

Permalink
subscriber: update tracing-core to v0.1.33 (tokio-rs#3201)
Browse files Browse the repository at this point in the history
The change tokio-rs#2954 was released in 0.3.19 (tokio-rs#3162).

Notably, it relied on features from tracing-core 0.1.33, however, the
version was never bumped. Users of the `tracing` feature of
`tracing-subscriber` would have no issue since it pulls in the higher
version transitively.

The specific feature used was implementing trait method `record_bytes`
from the `field::Visit` trait on `JsonVisitor` from the
tracing-subscriber json format module. (see linked tokio-rs#2945, or [ `impl
field::Visit for
JsonVisitor<'_>`](https://github.com/tokio-rs/tracing/blame/master/tracing-subscriber/src/fmt/format/json.rs#L491))

I believe this dependency mismatch requires users to manually select the
higher tracing-core version or suffer compilation failure.

This probably reflects some failure in how the tests utilize features
and intra-workspace dependencies, but, a resolution for that is beyond
my current comprehension of the project.
  • Loading branch information
hds authored Jan 27, 2025
1 parent 6240c95 commit bfca546
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tracing-subscriber/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ local-time = ["time/local-offset"]
nu-ansi-term = ["dep:nu-ansi-term"]

[dependencies]
tracing-core = { path = "../tracing-core", version = "0.1.30", default-features = false }
tracing-core = { path = "../tracing-core", version = "0.1.33", default-features = false }

# only required by the filter feature
tracing = { optional = true, path = "../tracing", version = "0.1.41", default-features = false }
Expand Down

0 comments on commit bfca546

Please sign in to comment.