Lean: Make the RISC-V Sail model build #1012
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasgrosser
force-pushed
the
lean-build-riscv-full
branch
from
fabe059 to
1784f69
Compare
Test Results 13 files 27 suites 0s ⏱️ Results for commit a9936a5. ♻️ This comment has been updated with latest results. |
This was referenced Feb 15, 2025
|
Let's keep this as draft, until #1015 is merged. |
The only semantic change this PR proposes is to not assert on argument pattern that we cannot yet translate, but instead to record them as `TODO_ARG_PATTERN`. This is sufficient to build the full RISC-V Sail model without assertions and with about 3500 warnings and errors remaining. This PR also introduces a GitHub action to validate that the RISC-V model builds. The RISC-V model currently requires two patches (one in Ryan's repository and one applied through this patch). Over time, we expect to switch to the main RISC-V repo. Co-authored-by: Léo Stefanesco <[email protected]>
tobiasgrosser
force-pushed
the
lean-build-riscv-full
branch
from
1784f69 to
20342a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only semantic change this PR proposes is to not assert on argument pattern that we cannot yet translate, but instead to record them as
TODO_ARG_PATTERN. This is sufficient to build the full RISC-V Sail model without assertions and with about 3500 warnings and errors remaining.This PR also introduces a GitHub action to validate that the RISC-V model builds. The RISC-V model currently requires two patches (one in Ryan's repository and one applied through this patch). Over time, we expect to switch to the main RISC-V repo.