Track location in pre-processed file, as well references to source. #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do this by introducing a new module `Cerb_location.position`, which replaces `Lexing.position` as the base type to use for positions. Values of the new position type keepl the `Lexing.position` corresponding to the actual location in the preprocessed file, as well as the file name and line in the original source assocaited with the location.
|
@kmemarian @cp526 this PR contains the changes to the lexer and parser to keep track of both the position in the pre-processed file, and also the position in the original source. Please have a look and let me know what you think. At the moment the position in the actual file is not really used, but the next step would be to modify the injection code |
* Add a way to ask for cartesian location in pre-processed or user visible file * Add a way to save the pre-processed file, if needed * Add code paths to optionally inject using either cartesian coordinates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step of solving #823.
We introduce a new module
Cerb_location.position, which defines a type replacingLexing.positionas the base type to use for positions. Values of the new position type keep theLexing.positioncorresponding to the actual location in the preprocessed file, as well as the file name and line in the original source associated with the location.