Skip and report invalid filenames when syncing #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adal-chiriliuc-reef
force-pushed
the
invalid-unicode
branch
from
138394c to
5a780fe
Compare
mjurbanski-reef
suggested changes
May 3, 2024
|
please add unit test |
adal-chiriliuc-reef
force-pushed
the
invalid-unicode
branch
from
d64996b to
f05bf97
Compare
mjurbanski-reef
suggested changes
May 3, 2024
|
|
||
| assert reporter.has_warnings_or_errors() | ||
| assert len(reporter.warnings) == 2 | ||
| assert "has an invalid filename (file names must not contain '\\'). Skipping" in reporter.warnings[ |
There was a problem hiding this comment.
please assert that not only explanation what is wrong to the user, but also filename with path is shown to them so they can go to the exact file and fix it
adal-chiriliuc-reef
force-pushed
the
invalid-unicode
branch
from
20f039a to
3075ae6
Compare
adal-chiriliuc-reef
force-pushed
the
invalid-unicode
branch
from
3075ae6 to
b71056b
Compare
adal-chiriliuc-reef
force-pushed
the
invalid-unicode
branch
from
b71056b to
055c56c
Compare
This reverts commit 3517791.
mjurbanski-reef
force-pushed
the
invalid-unicode
branch
3 times, most recently
from
b7f0a36 to
0774eb0
Compare
mjurbanski-reef
force-pushed
the
invalid-unicode
branch
from
0774eb0 to
08212cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report invalid filenames when syncing and skip them, instead of crashing.