Change auhtorize account signature #327
Conversation
There was a problem hiding this comment.
Isn't it a valid case of having a GitHub ticket, just from a different repo, assigned here?
There was a problem hiding this comment.
would be, but town crier doesn't support it, so this will just yield a broken link
There was a problem hiding this comment.
Also, this wouldn't be valid with the latest nox -s towncrier_check
| @@ -116,7 +116,11 @@ def setUp(self): | |||
| (self.application_key_id, self.master_key) = self.raw_api.create_account() | |||
|
|
|||
| def _authorize_account(self): | |||
| self.api.authorize_account('production', self.application_key_id, self.master_key) | |||
| self.api.authorize_account( | |||
| realm='production', | |||
There was a problem hiding this comment.
Nitpick: all other changes to kwargs resulted in placing realm being placed as last in the invocation.
| @@ -39,7 +39,11 @@ def setUp(self): | |||
| self.application_key_id, self.master_key = self.raw_api.create_account() | |||
|
|
|||
| def _authorize_account(self): | |||
| self.api.authorize_account('production', self.application_key_id, self.master_key) | |||
| self.api.authorize_account( | |||
| realm='production', | |||
There was a problem hiding this comment.
Nitpick: all other changes to kwargs resulted in placing realm being placed as last in the invocation.
| @@ -209,13 +209,13 @@ def authorize_automatically(self): | |||
| return self.session.authorize_automatically() | |||
|
|
|||
| @limit_trace_arguments(only=('self', 'realm')) | |||
| def authorize_account(self, realm, application_key_id, application_key): | |||
| def authorize_account(self, application_key_id, application_key, realm='production'): | |||
There was a problem hiding this comment.
I was considering asking for providing remaining realm options as e.g. Literal type or in the docstring. But these additional options are only for B2 developers, right? So it probably wouldn't make sense to add it here :/
No description provided.