Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom animations to Dialog #261

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

ghsteff
Copy link
Contributor

@ghsteff ghsteff commented Oct 21, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the new behavior?

You can customize Dialog animations using motionProps

Does this PR introduce a breaking change?

[ ] Yes
[x] No
Screen.Recording.2024-10-21.at.6.42.20.PM.mov

@ghsteff ghsteff requested a review from amcdnl October 21, 2024 23:43
Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for reablocks-storybook ready!

Name Link
🔨 Latest commit 2f6ff8f
🔍 Latest deploy log https://app.netlify.com/sites/reablocks-storybook/deploys/6717d6ae61186800088d29a3
😎 Deploy Preview https://deploy-preview-261--reablocks-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

/**
* Custom motion props to override default animations.
*/
motionProps?: MotionProps;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just extend the interface w/ these props so you don't have to pass an object? Seems more natural to do that imo.

Copy link
Member

@amcdnl amcdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add this to Tooltip and Popover?

@amcdnl amcdnl merged commit 6e09f8c into master Oct 22, 2024
5 checks passed
@amcdnl amcdnl deleted the feat/Add-custom-animations-to-dialog branch October 22, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants