Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend button theme to allow for allowable prop customizations #247

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

steppy452
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Button components allow custom variants, colors and sizes but theme does not fully support these customizations.

Issue Number: N/A

What is the new behavior?

This update allows

  • custom variants to be included in the colors theme
  • custom sizes to be themable
  • adds storybook stories

image

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link

vercel bot commented Jul 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
reablocks-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 9:03pm

Copy link

netlify bot commented Jul 19, 2024

Deploy Preview for reablocks-storybook ready!

Name Link
🔨 Latest commit 30bc5cc
🔍 Latest deploy log https://app.netlify.com/sites/reablocks-storybook/deploys/669ad4ac62dc4f000830f4e5
😎 Deploy Preview https://deploy-preview-247--reablocks-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@steppy452 steppy452 merged commit 5fd402a into master Jul 19, 2024
7 checks passed
@steppy452 steppy452 deleted the syang/extend-button-theme branch July 19, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants