fix show all feature for json tree #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for reablocks-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ghsteff
approved these changes
Jul 18, 2024
Comment on lines
+18
to
20
| * The limit for the number of nodes to show when `showAll` is false. | ||
| */ | ||
| showAllLimit?: number; |
There was a problem hiding this comment.
showAllLimit is kind of a confusing name imo, but I get you're not tryna break the API. Not even sure what a good name would be anyway, maybe expandCount - similar to the existing expandDepth
There was a problem hiding this comment.
eh none of those are great haha
There was a problem hiding this comment.
Agreed odd name but she just followed the other name. I think fine for now.
There was a problem hiding this comment.
yea didn't want to change it as it'd be a breaking change
amcdnl
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #245
What is the new behavior?
showAlldefaults infinity list size toInfinityand ignores showAllLimit. it also gets propagated through to child nodesshowAllLimitgets propagated through to child nodes. also updated the comment to show whenshowAllis falseshowAllDoes this PR introduce a breaking change?
Other information