Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add containerClassName to Select #244

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

ghsteff
Copy link
Contributor

@ghsteff ghsteff commented Jul 18, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] Other... Please describe: Improvement

What is the current behavior?

There's no way to customize the span that wraps Select

What is the new behavior?

You can pass a className to the Select parent span with the prop containerClassName

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link

vercel bot commented Jul 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
reablocks-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 5:57pm

Copy link

netlify bot commented Jul 18, 2024

Deploy Preview for reablocks-storybook ready!

Name Link
🔨 Latest commit 0b6dfec
🔍 Latest deploy log https://app.netlify.com/sites/reablocks-storybook/deploys/6699578ba88d5a000817a560
😎 Deploy Preview https://deploy-preview-244--reablocks-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ghsteff ghsteff marked this pull request as ready for review July 18, 2024 18:03
@ghsteff ghsteff merged commit 0747ca3 into master Jul 18, 2024
7 checks passed
@ghsteff ghsteff deleted the Add-containerClassName-to-Select branch July 18, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants