Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow theming visibleRange for pager #243

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Allow theming visibleRange for pager #243

merged 2 commits into from
Jul 18, 2024

Conversation

SerhiiTsybulskyi
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Screenshot 2024-07-18 at 17 37 19

@SerhiiTsybulskyi SerhiiTsybulskyi requested a review from amcdnl July 18, 2024 14:43
@SerhiiTsybulskyi SerhiiTsybulskyi self-assigned this Jul 18, 2024
Copy link

vercel bot commented Jul 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
reablocks-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 3:13pm

Copy link

netlify bot commented Jul 18, 2024

Deploy Preview for reablocks-storybook ready!

Name Link
🔨 Latest commit bce841e
🔍 Latest deploy log https://app.netlify.com/sites/reablocks-storybook/deploys/669930ec08a87800084c5e3b
😎 Deploy Preview https://deploy-preview-243--reablocks-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -28,6 +29,7 @@ const baseTheme: PagerTheme = {
},
ellipsis: 'cursor-pointer',
pagerDisplayItems: 'mr-1.5',
visibleRange: '',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name isn't the most obvious - What about showPageCount or something ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-07-18 at 18 03 36

showPageCount it not suitable, need to define only visible (shown) items

maybe shownItems will be better.
What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about - showPageRange

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good for me, I'll update

@amcdnl amcdnl merged commit 75bb78b into master Jul 18, 2024
7 checks passed
@amcdnl amcdnl deleted the pager-customization branch July 18, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants