Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checking "is the day in range" #237

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Fix checking "is the day in range" #237

merged 1 commit into from
Jul 8, 2024

Conversation

SerhiiTsybulskyi
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

When end date of range end of the day (Wed Jul 31 2024 23:59:59) calendar highlight the next day which should not be highlighted
Screenshot 2024-07-04 at 12 09 39

What is the new behavior?

Screenshot 2024-07-04 at 12 10 32

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@SerhiiTsybulskyi SerhiiTsybulskyi self-assigned this Jul 4, 2024
Copy link

vercel bot commented Jul 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
reablocks-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2024 9:15am

Copy link

netlify bot commented Jul 4, 2024

Deploy Preview for reablocks-storybook ready!

Name Link
🔨 Latest commit 8fc2028
🔍 Latest deploy log https://app.netlify.com/sites/reablocks-storybook/deploys/6686682415ba5b0008c06d4d
😎 Deploy Preview https://deploy-preview-237--reablocks-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SerhiiTsybulskyi SerhiiTsybulskyi marked this pull request as draft July 4, 2024 11:00
@SerhiiTsybulskyi SerhiiTsybulskyi marked this pull request as ready for review July 4, 2024 11:00
@amcdnl amcdnl merged commit 65c84a9 into master Jul 8, 2024
7 checks passed
@amcdnl amcdnl deleted the calendar-range-issue branch July 8, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants