Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add root rendering option to JsonTree #224

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

ghsteff
Copy link
Contributor

@ghsteff ghsteff commented Jun 6, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The root node is always rendered in the JsonTree component

What is the new behavior?

You can control whether the root node is rendered using the root prop

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Screen.Recording.2024-06-06.at.3.24.45.PM.mov

Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
reablocks-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 8:27pm

@ghsteff ghsteff requested review from amcdnl and steppy452 June 6, 2024 20:27
Copy link

netlify bot commented Jun 6, 2024

Deploy Preview for reablocks-storybook ready!

Name Link
🔨 Latest commit 616aeac
🔍 Latest deploy log https://app.netlify.com/sites/reablocks-storybook/deploys/66621ba51d4ce700085450f3
😎 Deploy Preview https://deploy-preview-224--reablocks-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amcdnl amcdnl merged commit dbd0eda into master Jun 6, 2024
7 checks passed
@amcdnl amcdnl deleted the feat/Add-root-JsonTree-prop branch June 6, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants