Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add breadcrumbs component #176

Merged
merged 5 commits into from
May 13, 2024
Merged

Add breadcrumbs component #176

merged 5 commits into from
May 13, 2024

Conversation

ghsteff
Copy link
Contributor

@ghsteff ghsteff commented May 13, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Screen.Recording.2024-05-13.at.9.51.12.AM.mov

@ghsteff ghsteff requested a review from amcdnl May 13, 2024 13:53
Copy link

netlify bot commented May 13, 2024

Deploy Preview for reablocks-storybook ready!

Name Link
🔨 Latest commit 816a1e5
🔍 Latest deploy log https://app.netlify.com/sites/reablocks-storybook/deploys/66425c3441bb650008d96b12
😎 Deploy Preview https://deploy-preview-176--reablocks-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

import React, { FC } from 'react';
import { BreadcrumbsTheme } from './BreadcrumbsTheme';

const Chevron = () => (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the Arrow component for tyhis?

Copy link
Member

@amcdnl amcdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor tweak

Copy link
Member

@amcdnl amcdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add a docs mdx file

@amcdnl amcdnl merged commit af42d49 into master May 13, 2024
5 checks passed
@amcdnl amcdnl deleted the Add-breadcrumbs branch May 13, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants