Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some Billing blocks #165

Merged
merged 5 commits into from
May 3, 2024
Merged

Add some Billing blocks #165

merged 5 commits into from
May 3, 2024

Conversation

ghsteff
Copy link
Contributor

@ghsteff ghsteff commented May 2, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This adds 2 Billing blocks

Screen.Recording.2024-05-02.at.3.35.20.PM.mov

@ghsteff ghsteff requested review from amcdnl and steppy452 May 2, 2024 20:37
Copy link

netlify bot commented May 2, 2024

Deploy Preview for reablocks-storybook ready!

Name Link
🔨 Latest commit c3e8278
🔍 Latest deploy log https://app.netlify.com/sites/reablocks-storybook/deploys/66342aeab2e0260008ccf251
😎 Deploy Preview https://deploy-preview-165--reablocks-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

TabPanel,
Stack,
Divider
} from '../../../src/layout';
Copy link
Member

@amcdnl amcdnl May 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should update these imports ( in the MDX ) to be from reablocks so people can copy paste easier.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right gotcha

@@ -8,3 +8,4 @@ We offer the following blocks to help you build your administration pages:

- Profile
- Pricing
- Billing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to add to the main intro

amcdnl
amcdnl previously requested changes May 2, 2024
Copy link
Member

@amcdnl amcdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few minor tweaks, otherwise awesome stuff

@ghsteff ghsteff dismissed amcdnl’s stale review May 3, 2024 00:08

Addressed feedback

@ghsteff ghsteff merged commit 69e7b04 into master May 3, 2024
5 checks passed
@ghsteff ghsteff deleted the Add-billing-block branch May 3, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants