Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated InlineInput #160

Closed
wants to merge 6 commits into from
Closed

Updated InlineInput #160

wants to merge 6 commits into from

Conversation

devconn99
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for reablocks-storybook ready!

Name Link
🔨 Latest commit c3c27c7
🔍 Latest deploy log https://app.netlify.com/sites/reablocks-storybook/deploys/66310ebd0ea6b3000921db8b
😎 Deploy Preview https://deploy-preview-160--reablocks-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@devconn99 devconn99 requested a review from ghsteff April 29, 2024 19:49
Copy link
Contributor

@ghsteff ghsteff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooop this affects SelectInput - the placeholder text and selections aren't visible anymore
image

@devconn99 devconn99 requested a review from ghsteff April 30, 2024 15:32
Comment on lines +90 to +92
{!placeholderIsMinWidth === true && !inputValue && (
<span className={spanStyles}>{placeholder}</span>
)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This !placeholderIsMinWidth === true seems backwards. Now a component like this has a width of 0 and the placeholder isn't visible

InlineInput
  placeholder="Type here..."
  placeholderIsMinWidth
/>

@amcdnl amcdnl self-requested a review May 3, 2024 09:39
@amcdnl
Copy link
Member

amcdnl commented May 3, 2024

@devconn99 - I think we are closing to having this merged, just a few minor tweaks.

@amcdnl
Copy link
Member

amcdnl commented May 15, 2024

@devconn99 - I believe we need to take a approach like this - https://dev.to/zechdc/autosize-input-field-plain-js-and-react-examples-38kb ... Are you interested in taking that on?

@amcdnl
Copy link
Member

amcdnl commented May 15, 2024

solved w/ - #186

@amcdnl amcdnl closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants