-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated InlineInput #160
Updated InlineInput #160
Conversation
✅ Deploy Preview for reablocks-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{!placeholderIsMinWidth === true && !inputValue && ( | ||
<span className={spanStyles}>{placeholder}</span> | ||
)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This !placeholderIsMinWidth === true
seems backwards. Now a component like this has a width of 0 and the placeholder isn't visible
InlineInput
placeholder="Type here..."
placeholderIsMinWidth
/>
@devconn99 - I think we are closing to having this merged, just a few minor tweaks. |
@devconn99 - I believe we need to take a approach like this - https://dev.to/zechdc/autosize-input-field-plain-js-and-react-examples-38kb ... Are you interested in taking that on? |
solved w/ - #186 |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information