Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ref to be an input element #155

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

steppy452
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #141 #154

What is the new behavior?

since only the inputRef is being passed through to AutosizeInput, it's unnecessary to pass the entire RefObject which is causing the type error with vitest.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Instead of passing an InputRef RefObject, just passing the inputRef ref portion of that object will be enough as the rest of the RefObject is not being utilized

Other information

@steppy452 steppy452 requested a review from amcdnl April 24, 2024 22:06
Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for reablocks-storybook ready!

Name Link
🔨 Latest commit 843bfcb
🔍 Latest deploy log https://app.netlify.com/sites/reablocks-storybook/deploys/66298259f3e6e80008f49a7f
😎 Deploy Preview https://deploy-preview-155--reablocks-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@devconn99
Copy link

I was able to check this update locally, and the error was resolved.
Thanks for taking a look, @steppy452!

@steppy452 steppy452 marked this pull request as ready for review April 25, 2024 14:54
@steppy452 steppy452 merged commit affe021 into master Apr 25, 2024
5 checks passed
@steppy452 steppy452 deleted the syang/141/inline-input-ref branch April 25, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants