-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update chip theme #151
Merged
Merged
Update chip theme #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reablocks-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
1a64fa1
to
36941c6
Compare
amcdnl
reviewed
Apr 24, 2024
amcdnl
reviewed
Apr 24, 2024
tailwind.config.ts
Outdated
}, | ||
error: { | ||
DEFAULT: colorPalette.red[500], | ||
active: colorPalette.red[500], | ||
hover: colorPalette.red[400], | ||
fill: colorPalette.red[100] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs need to be updated for this.
You have a conflict now 😝 |
amcdnl
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
This updates
ChipTheme
. Existing applications that overwrite or extendChipTheme
will have to update to match the new shapeOther information
Dark mode
Screen.Recording.2024-04-24.at.1.50.24.PM.mov
Light mode
Screen.Recording.2024-04-24.at.1.50.54.PM.mov
Note: The border of the selected default outlined tag in light mode is the same color as the storybook background so you can't see it