Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chip theme #151

Merged
merged 5 commits into from
Apr 26, 2024
Merged

Update chip theme #151

merged 5 commits into from
Apr 26, 2024

Conversation

ghsteff
Copy link
Contributor

@ghsteff ghsteff commented Apr 24, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] Other... Please describe: Theme update

Does this PR introduce a breaking change?

[x] Yes
[ ] No

This updates ChipTheme. Existing applications that overwrite or extend ChipTheme will have to update to match the new shape

Other information

Dark mode

Screen.Recording.2024-04-24.at.1.50.24.PM.mov

Light mode

Screen.Recording.2024-04-24.at.1.50.54.PM.mov

Note: The border of the selected default outlined tag in light mode is the same color as the storybook background so you can't see it

Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for reablocks-storybook ready!

Name Link
🔨 Latest commit 8e164d3
🔍 Latest deploy log https://app.netlify.com/sites/reablocks-storybook/deploys/662ba53681dfe6000841eabb
😎 Deploy Preview https://deploy-preview-151--reablocks-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ghsteff ghsteff force-pushed the Update-chip-theme branch from 1a64fa1 to 36941c6 Compare April 24, 2024 18:56
},
error: {
DEFAULT: colorPalette.red[500],
active: colorPalette.red[500],
hover: colorPalette.red[400],
fill: colorPalette.red[100]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs need to be updated for this.

@amcdnl
Copy link
Member

amcdnl commented Apr 26, 2024

You have a conflict now 😝

@amcdnl amcdnl merged commit 8996272 into master Apr 26, 2024
5 checks passed
@amcdnl amcdnl deleted the Update-chip-theme branch April 26, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants