Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ref typing and pass on inputRef #150

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Conversation

steppy452
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #141

What is the new behavior?

Typing for the ref has been updated to a RefObject so that inputRef can be passed on instead of the entire ref object.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@steppy452 steppy452 requested a review from amcdnl April 24, 2024 17:40
Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for reablocks-storybook ready!

Name Link
🔨 Latest commit 3a5b7b8
🔍 Latest deploy log https://app.netlify.com/sites/reablocks-storybook/deploys/662943fe7afb1700091ae29b
😎 Deploy Preview https://deploy-preview-150--reablocks-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amcdnl amcdnl merged commit 7ba651b into master Apr 24, 2024
5 checks passed
@amcdnl amcdnl deleted the syang/141/tests-failing branch April 24, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants