Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to define custom keys to create values in select #145

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

SerhiiTsybulskyi
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@SerhiiTsybulskyi SerhiiTsybulskyi self-assigned this Apr 18, 2024
Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for reablocks-storybook ready!

Name Link
🔨 Latest commit 899544a
🔍 Latest deploy log https://app.netlify.com/sites/reablocks-storybook/deploys/66211c89d6836d0008c5879a
😎 Deploy Preview https://deploy-preview-145--reablocks-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SerhiiTsybulskyi SerhiiTsybulskyi requested a review from amcdnl April 18, 2024 11:54
*/
valuesSplitterKeyCodes?: string[];
selectOnKeys?: string[];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we improve this type? Is there a keycode type the browser has we could use ?

@amcdnl amcdnl merged commit e9acf82 into master Apr 18, 2024
5 checks passed
@amcdnl amcdnl deleted the extend-select branch April 18, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants