Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON Tree #142

Merged
merged 15 commits into from
Apr 16, 2024
Merged

JSON Tree #142

merged 15 commits into from
Apr 16, 2024

Conversation

amcdnl
Copy link
Member

@amcdnl amcdnl commented Apr 16, 2024 •
edited
Loading

This PR:

  • Adds new JSON Tree
  • Fixes bug in Tree where empty children still show open arrow
  • Removes lodash depedency on collapse
  • Add missing className prop to TreeNode
image image

@amcdnl amcdnl requested a review from SerhiiTsybulskyi April 16, 2024 10:01
@amcdnl amcdnl self-assigned this Apr 16, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 16, 2024 •
edited
Loading

✅ Deploy Preview for reablocks ready!

Name Link
🔨 Latest commit 87c4de7
🔍 Latest deploy log https://app.netlify.com/sites/reablocks/deploys/661e933e5e8e31000835cac7
😎 Deploy Preview https://deploy-preview-142--reablocks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amcdnl amcdnl mentioned this pull request Apr 16, 2024
Closed
@SerhiiTsybulskyi
Copy link
Contributor

SerhiiTsybulskyi commented Apr 16, 2024 •
edited
Loading

  • Updated parseJsonTree to show index for array type and key for object type
  • Hide expand button for empty object
  • Display "" for empty strings
  • Fix displaying boolean values
  • Hide empty values when on flag showEmpty
  • Update label color for light theme

Screenshot 2024-04-16 at 17 57 18
Screenshot 2024-04-16 at 17 57 24
Screenshot 2024-04-16 at 17 57 34
Screenshot 2024-04-16 at 18 03 46

@SerhiiTsybulskyi SerhiiTsybulskyi marked this pull request as ready for review April 16, 2024 15:41
@amcdnl amcdnl merged commit e2384f8 into master Apr 16, 2024
5 checks passed
@amcdnl amcdnl deleted the jsontree branch April 16, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SerhiiTsybulskyi SerhiiTsybulskyi Awaiting requested review from SerhiiTsybulskyi

Assignees

@amcdnl amcdnl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amcdnl @SerhiiTsybulskyi