-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove previously deprecated methods and types #2277
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
204bcd1
Remove previously deprecated methods and types
bsideup 20f13a5
un-deprecate some methods, remove unused classes
bsideup f3fb770
add japicmp exclusions
bsideup 62f227d
exclude `onLastAssembly` from japicmp
bsideup aa5b06a
remove `expectNoEvent`
bsideup b02c0f1
downgrade to japicmp 0.2.6
bsideup 097b048
merge `{Flux,Mono}{RetryPredicate,When}Test`s
bsideup 2e77722
remove html japicmp reports
bsideup File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
458 changes: 0 additions & 458 deletions
458
reactor-core/src/main/java/reactor/core/publisher/Flux.java
Large diffs are not rendered by default.
Oops, something went wrong.
455 changes: 0 additions & 455 deletions
455
reactor-core/src/main/java/reactor/core/publisher/Mono.java
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, I don't think this one should be removed :( It looks like it was deprecated by mistake, because ultimately the one we'd want removed is the one with a
Consumer<Subscription>
(see the TODO onsubscribe
variant with such aConsumer
below)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert the removal of that method, and delete the
@Deprecated
instead 🙇