Enhanced lifecycle-aware module registry #849
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheRogue76
reviewed
Jan 6, 2025
Comment on lines
+76
to
+81
| @implementation AppDelegate | ||
| - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions { | ||
| [[RNLifecycleManager sharedInstance] notifyModulesWithSelector:@selector(applicationDidFinishLaunching:) application:application]; | ||
| return YES; | ||
| } | ||
| @end |
There was a problem hiding this comment.
Perhaps it would be best if this was internal in RN itself (maybe via method swizzling or having some standard interface from core that is exposed and the app delegate implements) this way we can make changes without any user facing breaking API
There was a problem hiding this comment.
My main goal is simply to show, in basic terms, how this works. The actual implementation will occur internally inRCTAppDelegate, so there’s no need for user-facing changes. I’ll revise the examples to avoid confusion for others.
TheRogue76
reviewed
Jan 6, 2025
Comment on lines
+117
to
+127
| class MainApplication : Application() { | ||
| override fun onCreate() { | ||
| super.onCreate() | ||
| LifecycleManager.notify { it.onCreate(this) } | ||
| } | ||
|
|
||
| override fun onTerminate() { | ||
| super.onTerminate() | ||
| LifecycleManager.notify { it.onDestroy() } | ||
| } | ||
| } |
TheRogue76
reviewed
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This RFC proposes a framework to enhance the module registry in React Native by introducing a lifecycle-aware system for native modules. The goal is to address the current gap in handling application lifecycle events, similar to Flutter's
FlutterApplicationLifeCycleDelegateon iOS andApplication.ActivityLifecycleCallbackson Android. The design enables seamless integration of native modules with application lifecycle events across iOS and Android platforms. There is also Expo Modules Core that handles this viaExpoAppDelegateSubscriberandReactActivityLifecycleListener, but React Native does not have this by default and it requires Expo to be used in such cases.A rendered version of the proposal can be read here