Skip to content
This repository has been archived by the owner on Jun 21, 2021. It is now read-only.

Suggestions for optimization #4

Merged
merged 1 commit into from
May 5, 2015
Merged

Conversation

aheusingfeld
Copy link
Contributor

Configuration

  • added confluenceCreateSubpages parameter to be able to switch off creation of subpages
  • changed input parameter into a list of files
  • one can now also configure a parent page by file

asciidoc2confluence

  • adopted new config parameters
  • added more log output
  • added check whether 'ancestorId' is provided, if not a new master page will be created

README

  • switched from Markdown to Asciidoc
  • added section about usage with Maven and GMavenPlus

FIXME

  • added the scriptBasePath variable which now MUST be set as otherwise the asciidoc2confluence.groovy will not be able to find the Config.groovy file. Couldn't find a better way to retrieve the path to the Config.groovy file. Suggestions and optimizations are very welcome!

Configuration
- added `confluenceCreateSubpages` parameter to be able to switch off creation of subpages
- changed `input` parameter into a list of files
- one can now also configure a parent page by file

asciidoc2confluence
- added `scriptBasePath` variable which now MUST be set (couldn't find a better way to get the path to the Config.groovy file. Suggestions welcome!)
- adopted new config parameters
- added more log output
- added check whether 'ancestorId' is provided, if not a new master page will be created

README
- switched from Markdown to Asciidoc
- added section about usage with Maven and GMavenPlus
rdmueller added a commit that referenced this pull request May 5, 2015
Suggestions for optimization
@rdmueller rdmueller merged commit 97ea713 into rdmueller:master May 5, 2015
@rdmueller
Copy link
Owner

Wow. Thanx for the rebase...!

@aheusingfeld
Copy link
Contributor Author

Thanks for all your effort on the script, it works like a charm. I see 2 more tasks to make the script even more convenient to use

  1. Think about proper packaging + versioning so that people can include the script as a dependency into their build
  2. (will come in as we discuss 1.): Once we have a package, we need to find a better way to handle the configuration

Maybe @gernotstarke or @mojavelinux have more input on this.

@mojavelinux
Copy link

I love the idea of this script, though I wonder if it would be possible to align efforts with https://github.com/asciidoctor/asciidoctor-confluence. More ideas on where we are headed with this script are outlined in the following post: http://discuss.asciidoctor.org/Asciidoctor-CMS-publisher-td3022.html

cc: @gscheibel

@rdmueller
Copy link
Owner

@mojavelinux : Good Idea! When I started with this script I wasn't aware of the asciidoctor-confluence plugin, but I have no problem to drop this project for an equal asciidoctor plugin. Let's see - my ruby knowledge is limited at the moment... created issue #5 to align efforts

@mojavelinux
Copy link

👍

If you know Groovy, you know Ruby...it really is very similar. That's basically how I figured it out.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants