[rtext] Adjust font atlas area calculation so padding area is not underestimated at small font sizes. #3719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erestimated at small font sizes.
|
@tromero thanks for the review! This issue has been actually reviewed many times... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3717
The old padding*4 results in around 80px of padding area when the actual amount of padding area was 144px. Adding the padding to the width and height separately instead of only to width should give the exact amount of area after padding, and should better account for fonts with very wide glyphs. With this change I no longer lose glyphs even at impractically small font sizes in the 1-7px range. The 1.2x constant could potentially be reduced now that the area calculation is more accurate.