Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tmux-sessioner extension #16218

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Conversation

guidefari
Copy link
Contributor

@guidefari guidefari commented Jan 8, 2025

Description

  • Configure default directory to start new session in
  • Optional: select directory when creating new session

Screencast

Checklist

- chore: lint & format
- chore: update dependencies
- feat: specify directory
- Initial commit
@guidefari guidefari requested a review from sxn as a code owner January 8, 2025 06:51
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: tmux-sessioner Issues related to the tmux-sessioner extension labels Jan 8, 2025
@raycastbot
Copy link
Collaborator

raycastbot commented Jan 8, 2025

Thank you for your contribution! 🎉

🔔 @louishuyng @sxn @jasonshanks you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

Due to our current reduced availability, the initial review may take up to 10-15 business days 🎄

@jasonshanks
Copy link
Contributor

I like this extension is getting some renewed attention right now!

Not mine to say and I haven't downloaded the fork to check out yet but I think this is great, as long as the directory option can be left blank and not prompted for.

Not how I personally use tmux: every session has a different directory and navigating to one is far superior in the actual terminal (like I immediately reach for Zoxide).

What do you think @louishuyng ?

@louishuyng
Copy link
Contributor

I think the idea of setting up a new directory when starting a new tmux session is cool.

To be honest, i not usually create new session as i always defined my session using [tmuxinator](https://github.com/tmuxinator/tmuxinator)

But if i have a chance to setup directory for each new session i would like to follow the way

  1. User choose their default directory like @guidefari did in the first step
  2. When a user creates a new session, the Finder directory will open with the view set to the default directory established in step 1.

The reason is we usually focus on some main default directory (for me is ~/Dev/repository/github.com) then i will create session around that default directory

For example:

  • Company A Session will be in this directory ~/Dev/repository/github.com/companyA
  • Company B Session will be in this directory ~/Dev/repository/github.com/companyB
  • My personal Session will be in this directory ~/Dev/repository/github.com/louishuyng

@guidefari @jasonshanks what do you guys think if we follow above?

@jasonshanks
Copy link
Contributor

Yeah that suits me fine!

For the most part I create a lot of website repos in a main Sites folder. Then a bunch of other repos in a GitHub projects ones. But switching directories once I'm in is trivial. Great for this to meet as many needs as possible 😄

aside: I was trying check out an unpublished branch like this for the first time but following the guide ended in errors. I'm in fish but also tried zsh. Any suggestions what the syntax is supposed to be? I tried: git clone -n --depth=1 --filter=tree:0 -b $tmux-sessioner $https://github.com/guidefari/raycast-extensions.git

p.s. @guidefari just being listening to some DnB on Goosebumps. nice curation 👍

@guidefari
Copy link
Contributor Author

@jasonshanks @louishuyng yeah I have a similar workflow. Please check my latest commit to confirm if it's what you have in mind?


@jasonshanks thanks for checking out goosebumps! I'm also listening to mixes from there now😄

& RE the checking out my fork, here's what I ran, let me know if it works?

BRANCH="ext/tmux-sessioner"
FORK_URL="https://github.com/guidefari/raycast-extensions.git"
EXTENSION_NAME="tmux-sessioner"

git clone -n --depth=1 --filter=tree:0 -b ${BRANCH} ${FORK_URL}
cd raycast-extensions
git sparse-checkout set --no-cone "extensions/${EXTENSION_NAME}"
git checkout
cd "extensions/${EXTENSION_NAME}"
npm install && npm run dev

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Looks good to me, approved 🔥

@raycastbot raycastbot merged commit f430a87 into raycast:main Jan 9, 2025
9 checks passed
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Published to the Raycast Store:
https://raycast.com/louishuyng/tmux-sessioner

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension fix / improvement Label for PRs with extension's fix improvements extension: tmux-sessioner Issues related to the tmux-sessioner extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants