Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pytest-timeout to test dependencies #1433

Open
wants to merge 1 commit into
base: branch-25.02
Choose a base branch
from

Conversation

TomAugspurger
Copy link

@TomAugspurger TomAugspurger commented Jan 28, 2025

Right now the test suite warns that

dask_cuda/tests/test_dask_cuda_worker.py:354
  /home/nfs/toaugspurger/gh/rapidsai/dask-cuda/dask_cuda/tests/test_dask_cuda_worker.py:354: PytestUnknownMarkWarning: Unknown pytest.mark.timeout - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
    @pytest.mark.timeout(20)

Added pytest-timeout to dependencies.yaml and regenerated the conda environment.yaml files.

@TomAugspurger TomAugspurger requested a review from a team as a code owner January 28, 2025 22:58
@TomAugspurger TomAugspurger requested a review from bdice January 28, 2025 22:58
Copy link

copy-pr-bot bot commented Jan 28, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the conda conda issue label Jan 28, 2025
@TomAugspurger TomAugspurger force-pushed the tom/fix/pytest-timeout-marker branch 2 times, most recently from 0a8028a to 5295851 Compare January 29, 2025 12:43
Right now the test suite warns that

```
dask_cuda/tests/test_dask_cuda_worker.py:354
  /home/nfs/toaugspurger/gh/rapidsai/dask-cuda/dask_cuda/tests/test_dask_cuda_worker.py:354: PytestUnknownMarkWarning: Unknown pytest.mark.timeout - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
    @pytest.mark.timeout(20)
```

Signed-off-by: Tom Augspurger <[email protected]>
@TomAugspurger TomAugspurger force-pushed the tom/fix/pytest-timeout-marker branch from 5295851 to 2e559bf Compare January 29, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda conda issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant