-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Temporarily skip CUDA 11 wheel CI" #601
base: branch-25.02
Are you sure you want to change the base?
Conversation
This reverts commit 9b7bb97.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-25.02 #601 +/- ##
=============================================
Coverage 72.30% 72.30%
=============================================
Files 14 14
Lines 65 65
=============================================
Hits 47 47
Misses 18 18 ☔ View full report in Codecov by Sentry. |
good news: the wheel tests that had been failing because of the cuBLAS issues are passing! bad news: 1 wheel test
That looks like a numerical-precision thing (which can sometimes show up as a flaky test), but I observed it on consecutive runs. |
Hi @jameslamb , this PR will resolve the issue, pls rerun your tests to ignore it temporarily. |
How many times should we try a rerun? Looks like it's failed three times now. |
@vyasr @jameslamb cuVS CI started failing when the script to run the python tests was fixed. I’m not sure which tests were/weren’t running prior to that because I verified myself that there were Python tests running in CI prior to that fix. However, i suspect these tests hadn’t been running since October timeframe and that’s why we are now seeing failures. One failure seems related to CUBLAS, another seems related to precision or a bug in a distance function/computation. |
Oh wow! Thanks for that context.
Take a look at "cuVS CI failures" in rapidsai/build-planning#137. If what you're referring to is the same as those logs, then that issue is now fixed.
Ok yep, that's the one we're running into here, I think: #601 (comment) |
Well... it looks like getting consecutive Aces in a poker game.. I just rerun it, let's see and the #596 is close to pass all CI tests, at least we can count on merge it in advance.. |
Ha yes at this point I think we'll probably wind up waiting for #596 to finish CI, but since the wheel tests are fast no harm in attempting a rerun and seeing what happens. |
Reverts #599 now that rapidsai/raft#2548 has landed.