Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize whitespace #593

Open
wants to merge 2 commits into
base: branch-25.02
Choose a base branch
from
Open

Normalize whitespace #593

wants to merge 2 commits into from

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jan 20, 2025

This PR applies pre-commit hooks to normalize whitespace (trimming trailing whitespace and enforcing consistent end-of-file newlines).

These rules are already applied to most other RAPIDS repos, so this PR aligns with the norm in RAPIDS.

@bdice bdice requested review from a team as code owners January 20, 2025 20:32
@bdice bdice requested a review from jameslamb January 20, 2025 20:32
@bdice bdice self-assigned this Jan 20, 2025
@bdice bdice added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jan 20, 2025
jameslamb
jameslamb approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strongly support this, thank you for doing it.

@jameslamb jameslamb mentioned this pull request Jan 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@bdice bdice

Labels
CMake cpp improvement Improves an existing functionality non-breaking Introduces a non-breaking change Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdice @jameslamb