Add pylibcudf.null_mask.null_count #17711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
improvement
Matt711
approved these changes
Jan 14, 2025
| @@ -148,3 +150,28 @@ cpdef tuple bitmask_or(list columns): | |||
| c_result = cpp_null_mask.bitmask_or(c_table.view()) | |||
|
|
|||
| return buffer_to_python(move(c_result.first)), c_result.second | |||
|
|
|||
|
|
|||
| cpdef size_type null_count(Py_ssize_t bitmask, size_type start, size_type stop): | |||
There was a problem hiding this comment.
Are you using Py_ssize_t over int because the bitmask is essentially an index to a python buffer object? And according to this stackoverflow post. Py_ssize_t preffered over int when indexing into python objects.
There was a problem hiding this comment.
I was matching the ptr type of int_to_void_ptr here. Additionally, using int here would result in an OverflowError
Co-authored-by: Matthew Murray <[email protected]>
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A small step to not have
null_counttied tocudf._lib.column.ColumnChecklist