Skip to content

Commit

Permalink
Remove incorrect calls to set architectures (#17813)
Browse files Browse the repository at this point in the history
init_architectures sets this for us and invoking set_architectures before the project call produces the wrong result.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Robert Maynard (https://github.com/robertmaynard)

URL: #17813
  • Loading branch information
vyasr authored Jan 24, 2025
1 parent 9f3cb65 commit 77efd9b
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 12 deletions.
3 changes: 1 addition & 2 deletions cpp/examples/basic/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
# Copyright (c) 2020-2024, NVIDIA CORPORATION.
# Copyright (c) 2020-2025, NVIDIA CORPORATION.

cmake_minimum_required(VERSION 3.26.4)

include(../set_cuda_architecture.cmake)

# initialize cuda architecture
rapids_cuda_init_architectures(basic_example)
rapids_cuda_set_architectures(RAPIDS)

project(
basic_example
Expand Down
3 changes: 1 addition & 2 deletions cpp/examples/billion_rows/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
# Copyright (c) 2024, NVIDIA CORPORATION.
# Copyright (c) 2024-2025, NVIDIA CORPORATION.

cmake_minimum_required(VERSION 3.26.4)

include(../set_cuda_architecture.cmake)

# initialize cuda architecture
rapids_cuda_init_architectures(billion_rows)
rapids_cuda_set_architectures(RAPIDS)

project(
billion_rows
Expand Down
3 changes: 1 addition & 2 deletions cpp/examples/interop/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
# Copyright (c) 2024, NVIDIA CORPORATION.
# Copyright (c) 2024-2025, NVIDIA CORPORATION.

cmake_minimum_required(VERSION 3.26.4)

include(../set_cuda_architecture.cmake)

rapids_cuda_init_architectures(interop_example)
rapids_cuda_set_architectures(RAPIDS)

project(
interop_example
Expand Down
3 changes: 1 addition & 2 deletions cpp/examples/nested_types/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
# Copyright (c) 2023-2024, NVIDIA CORPORATION.
# Copyright (c) 2023-2025, NVIDIA CORPORATION.

cmake_minimum_required(VERSION 3.26.4)

include(../set_cuda_architecture.cmake)

# initialize cuda architecture
rapids_cuda_init_architectures(nested_types)
rapids_cuda_set_architectures(RAPIDS)

project(
nested_types
Expand Down
3 changes: 1 addition & 2 deletions cpp/examples/parquet_io/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
# Copyright (c) 2024, NVIDIA CORPORATION.
# Copyright (c) 2024-2025, NVIDIA CORPORATION.

cmake_minimum_required(VERSION 3.26.4)

include(../set_cuda_architecture.cmake)

# initialize cuda architecture
rapids_cuda_init_architectures(parquet_io)
rapids_cuda_set_architectures(RAPIDS)

project(
parquet_io
Expand Down
3 changes: 1 addition & 2 deletions cpp/examples/strings/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
# Copyright (c) 2022-2024, NVIDIA CORPORATION.
# Copyright (c) 2022-2025, NVIDIA CORPORATION.

cmake_minimum_required(VERSION 3.26.4)

include(../set_cuda_architecture.cmake)

# initialize cuda architecture
rapids_cuda_init_architectures(strings_examples)
rapids_cuda_set_architectures(RAPIDS)

project(
strings_examples
Expand Down

0 comments on commit 77efd9b

Please sign in to comment.