Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update dependencies.yaml convention docs #132

Merged
merged 2 commits into from
Jan 13, 2025
Merged

update dependencies.yaml convention docs #132

merged 2 commits into from
Jan 13, 2025

Conversation

jameslamb
Copy link
Member

Updates the dependencies.yaml convention docs based on this conversation: rapidsai/cugraph#4854 (comment)

@jameslamb jameslamb added doc Improvements or additions to documentation non-breaking Introduces a non-breaking change labels Jan 13, 2025
@jameslamb jameslamb requested a review from bdice January 13, 2025 14:14
@jameslamb jameslamb mentioned this pull request Jan 13, 2025
Merged
bdice
bdice reviewed Jan 13, 2025
View reviewed changes
docs/docs/packaging.md Outdated Show resolved Hide resolved
bdice
bdice approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One fix for a seemingly incomplete sentence, otherwise LGTM! Thanks.

@jameslamb jameslamb merged commit 1358981 into rapidsai:main Jan 13, 2025
@jameslamb jameslamb deleted the docs/depends-on branch January 13, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
doc Improvements or additions to documentation non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jameslamb @bdice